Implement Android sub/unsub callbacks

b8ne / react-native-pusher-push-notifications

Manage pusher interest subscriptions and notification events in Javascript.

MIT License

98 stars 86 forks source link

Implement Android sub/unsub callbacks #11

Closed augustoabreu closed 6 years ago

se1exin commented 7 years ago

Thanks @augustoabreu !

Looks good to me, but I'm going to leave this open until we get an iOS implementation as well so that both bases are covered.

I'll try and make time this weekend to do the iOS side

b8ne commented 6 years ago

Hey @augustoabreu thanks heaps for this. I have been away on other work so apologise for not getting to this sooner. I have merged into master just to get the code in there. I have just created another PR #19 to extend some of the work you did in implementing listeners and callbacks. The RN side should now be uniform and independent to Platforms. If you or @se1exin have a chance do you mind reviewing?