search

b8ne / react-native-pusher-push-notifications

Manage pusher interest subscriptions and notification events in Javascript.
MIT License
98 stars 86 forks source link

Notification callback not triggered on Android? #40

Closed emilkarl closed 3 years ago

emilkarl commented 5 years ago

I can't see any callbacks being triggered when opening the app by clicking the notification. The callbacks is called when the app is opened or in background.

Have you looked in to this @mikebridge @b8ne ?

emilkarl commented 5 years ago

I made a PR for supporting deep links in push-notifications-android. If we can get that merged we could update this lib to use that version and include a little pitch about deep linking in the readme.

I will also do something similar to the swift library for iOS so you will be able to use deep linking for both platforms.

https://github.com/pusher/push-notifications-android/pull/76

@mikebridge @b8ne @lukabratos what do you say?

emilkarl commented 5 years ago

I think using deep links would be a nicer way of handling opening the app from a notification than routing in a callback/listener so if anyone want to help I would appreciate it. :)

mikebridge commented 5 years ago

I had hoped to look at this yesterday but it probably won't be until next week. I'm not sure what you mean by the callbacks not being triggered when opening the app.

Ahmdrza commented 3 years ago

@emilkarl Hi, any updates on this issue?

Humni commented 3 years ago

Given the lack of update, I'll close this for now - if it is still an issue let me know