b8ne / react-native-pusher-push-notifications

Manage pusher interest subscriptions and notification events in Javascript.
MIT License
97 stars 85 forks source link

Errors building iOS with React Native 0.60.x #46

Closed stephenkiers closed 3 years ago

stephenkiers commented 4 years ago

So our company has used RNPusherPushNotifications for over a year in our RN app. This last week I started the upgrade to RN 0.60.x but I have been blocked by this package for the last couple days. Would really appreciate help.

So here are relevant portions of our app,

package.json

...
"dependencies": {
"react-native-pusher-push-notifications": "git+http://git@github.com/ZeptInc/react-native-pusher-push-notifications#v.2.4.1-zept-master",
}
...

react-native.config.js

module.exports = {
    dependencies: {
        "react-native-pusher-push-notifications": {
            platforms: {
                android: null,
                ios: null
            }
        }
    }
};

ios/Cartfile

github "pusher/push-notifications-swift" ~> 2.0.0

And I have added RNPusherPushNotifications.xcodeproj to our app's library and linked the binary to the library

Screenshot 2019-08-16 14 51 46

But, when I try to build... 22 Errors break the builds Aug-16-2019 14-56-18-2

So, I thought I would try changing the Header Search Paths in the RNPusherPushNotifications.xcodeprojproject to see if they were the cause of the issue (based on StackOverflow hints)

Aug-16-2019 14-58-20

1 Error breaks the build

Screenshot 2019-08-16 15 02 22 Screenshot 2019-08-16 15 02 40

Send HELP!?!

but I honestly don't know if that is a step forward or a step back.

Anyone else do this? Anyone have success yet? Any help that could be given is appreciated.

stephenkiers commented 4 years ago

Here are minimum repos for the issue : https://github.com/stephenkiers/PusherPushNotificationsSampleRepo/blob/react-native-init/README.md

stephenkiers commented 4 years ago

I created a pull request here : https://github.com/b8ne/react-native-pusher-push-notifications/pull/47 to address this issue

lsirdevan commented 4 years ago

@stephenkiers Thanks! Works great

@b8ne Could we get #47 merged? It fixes this issue

ErlanBelekov commented 4 years ago

@stephenkiers hey! did you resolve this? if yes, please tell how, I need this package to work so bad! Thanks

stephenkiers commented 4 years ago

yeah, you can check out this branch https://github.com/b8ne/react-native-pusher-push-notifications/pull/48 for the current working version we use internally.