bBoxType / Kernkraft

GNU General Public License v3.0
50 stars 5 forks source link

Doesn't include Thai numbers #18

Open boomwooq opened 5 years ago

boomwooq commented 5 years ago

Hi, I have been using the plugin for Thai script, it works well!

However, it doesn't include Thai numbers even though they're located in Number category. But in Punctuation category, it works perfectly fine, it draws out all the Thai punctuations in the section.

Mark2Mark commented 5 years ago

I just recently added Thai quickly (at least letters* should work?) and maybe didn’t add numerals yet. 1)

1) I’ll have a look


*) Left : khoKhwai khoKhwai doDek khoKhwai Right : khoKhwai doDek doDek khoKhwai-thai

2) Do you have a better recommendation (better than this one here above) for the letters?

3) Do you have a recommendation for the numerals sample stings?

boomwooq commented 5 years ago

Hey, sorry it took a while to reply. I have been discussed with others and couldn't find the agreement on what should be the control letters while doing the kerning since we use the different strings on loop and loopless version.

would it be possible to have the middle strings? If it could be then I would suggest this set of letters:

Loopless: นน(x)มมออ(x)ดด

Left: noNu-thai noNu-thai Middle: moMa-thai moMa-thai oAng-thai oAng-thai Right: doDek-thai doDek-thai

Loop** ผผ(x)ผผออ(x)ออ Left: phoPhung-thai phoPhung-thai Middle: phoPhung-thai phoPhung-thai oAng-thai oAng-thai Right: oAng-thai oAng-thai

*Only if they could have 2 sets of loop and loopless, but if it couldn't then I would suggest the loopless version as the default.

Numbers ๗๗(x)๒๒๐๐(x)๐๐ Left: seven-thai seven-thai Middle: two-thai two-thai zero-thai zero-thai Right: zero-thai zero-thai

Thank you for considering this!

Mark2Mark commented 5 years ago

Thank you very much @boomwooq !

I’ll think about how to control Loopless/Looped either in the UI or automatically. I also thought that this particularly is an issue. Maybe in the hidden extra drawer (button "…") I could add a radio-box to choose.

boomwooq commented 5 years ago

@Mark2Mark Totally love the idea!

Mark2Mark commented 5 years ago

Cool!

1) How about splitting the currently proposed middle strings into 2 lines? So instead of นน(x)มมออ(x)ดด it would be นน(x)มม ออ(x)ดด The reason I ask is because at the moment we favour for having the to-be-kerned-letter somewhat in the middle and you navigate your caret just up or down from one case to the next. But it’s not necessary to move left or right, which would increase the amount of steps.

2) Oh and what I forgot: if (x) is the currently to be kerned letter, where do the font’s itereated glyphs go in those strings?

Lets say you wanna kern A: the strings will be sth like: HHAAAHH HHBABHH HHCACHH

So A is your focused letter, HH are the context letters so that you can judge the overall spacing, and A … B … C … from line to line are the iterated glyphs you wanna see the A against. So I wonder where those go in your proposal? นน(x)มม needs to become something like นน(y)(x)(y)มม then. Or however you want.

boomwooq commented 5 years ago

@Mark2Mark Yea, separated the line could work too! But I would suggest adding one more letter in each so we can see the rhythm of the space in between straight/ cursive letters better, so it will be:

นนน(y)(x)(y)มมม อออ(y)(x)(y)ดดด

And sorry last time I didn't mention, I considered (x) as a whole x = (y)(x)(y) y= iterated glyphs