search

bBoxType / Kernkraft

GNU General Public License v3.0
50 stars 5 forks source link

Thai doesn't read its control letters #30

Open boomwooq opened 4 months ago

boomwooq commented 4 months ago

I think, it's no longer read Thai script CleanShot 2024-05-09 at 20 24 36@2x

Mark2Mark commented 4 months ago

Indeed. Thanks for reporting. Someone must have broken something in recent Glyphs updates. This plugin and its code is incredibly old and utilised lots of hacks back then. When I find the time I will need to properly clean up.

Hope I can fix this very issue soon. Sorry for that!

schriftgestalt commented 4 months ago

Can you point me to the code where it should read the control letters?

Mark2Mark commented 4 months ago

about here: https://github.com/bBoxType/Kernkraft/blob/cc6b987ec111222b6e7ce08204b5f2dafb76c3ef/Kernkraft.glyphsPlugin/Contents/Resources/KernKraftModule.py#L336

the customKenringStrings are defined in kernKit.py

"thai": {
    "Letter": {
        "Other": {
            "Left": "/thoThahan-thai/thoThahan-thai/doDek-thai/thoThahan-thai",
            "Right": "/thoThahan-thai/doDek-thai/doDek-thai/noNu-thai",
        },
        "Spacing": {
            "Left": "/khoKhwai-thai/khoKhwai-thai/doDek-thai/khoKhwai-thai",
            "Right": "/khoKhwai-thai/doDek-thai/doDek-thai/khoKhwai-thai",
        },
    },
},
schriftgestalt commented 4 months ago

glyphs.subCategory in not "Other" any more, it is just None.

schriftgestalt commented 4 months ago

I send a PR but didn’t test it.

Mark2Mark commented 4 months ago

Thanks! I will test later today ⏱️

boomwooq commented 2 weeks ago

@schriftgestalt Thank you! I did the test, works now