bLangved / Pokemon-Pokedex

1 stars 0 forks source link

Closed bLangved closed 6 months ago

bLangved commented 6 months ago

Originally #3 , but that was not possible as of now.

This now covers:

6 and #19

Primary:

Secondary:

Some class/id name-changes around the project
Altered Pokeball animation to be a bit simpler without text, since the pagination triggers it much more often, and it became a bit too much. Load times are quicker
Some minor style tweaks
Made loading and errorMessage containers into Astro components. Less clutter in the HTML
Made The section into an Astro Component with parameters to pass into

netlify[bot] commented 6 months ago

Name	Link
Latest commit	39f5c6a1e9f6bd667bac8a42c9f397ec37d1eb89
Latest deploy log	https://app.netlify.com/sites/pokedex4life/deploys/65e068710281ae0007c4a57b
Deploy Preview	https://deploy-preview-21--pokedex4life.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bLangved commented 6 months ago

When I am checking out the Netlify deploy preview, I can now see 2 issues:

The "More Pokemons" button pop up before the API call is finished. This should only happen after the pokeCards are shown.
The x.Generation is also still showing before the API call is finished. This should also be delayed to after (or at least be at top of site).

I will fix this tomorrow before you approve

bLangved commented 6 months ago

Original problem was this:

Generation title and showMorePpokeBtn was displaying before entries on api call. Since the call is async, it is difficult to get this right, since it shows when API call is ready (even though the html is not). Maybe a little better now, but not much.
Modularized the generation.js, and improved readability
Removed some unnecessary console.logs around the project
Also took the liberty of fixing so displaying geneneration on "selectedPokemon" page is possible (the nav in the header was not correct on all pages), by storing that genNumber is sessionStorage, and redirecting user, for then handling the function.