bSI-InfraRoom / IFC-Documentation

HTML documentation generated from IfcDoc
9 stars 14 forks source link

Error in IFC4x3_RC4.exp in definition of IfcSurfaceFeature #6

Closed RickBrice closed 3 years ago

RickBrice commented 3 years ago

There seems to be a bust in IFC4x3_RC4.exp that was introduced in the last commit (0912a44). Should RelatedSurfaceFeature be RelatedSurfaceFeature**s**?

Commit e373044

IfcSurfaceFeature_Commit_e373004

Commit 0912a44 IfcSurfaceFeature_Commit_0912a44

I found this issue generating code for IfcOpenShell IfcParse library using the latest IFC4x3_RC4.exp file from this repository.

RickBrice commented 3 years ago

This issue seems to persist after the 9ffbab2 commit

SergejMuhic commented 3 years ago

Addressed here https://github.com/bSI-InfraRoom/IFC-Specification/pull/192.

RickBrice commented 3 years ago

The documentation seems to be updated. However the typo remains in https://github.com/bSI-InfraRoom/IFC-Documentation/blob/main/4_3_0_0/rc4/EXPRESS/IFC4x3_RC4.exp

SergejMuhic commented 3 years ago

There was no new release of the documentation (happens in this repository). Currently, we are gathering feedback before a new release. Could probably arrange it as there are no formal requirements currently.

The updated documentation, schema and properties are however on the IFC-Specification repository in the Actions tab as the workflows run on changes.

https://github.com/bSI-InfraRoom/IFC-Specification/actions

You can filter the workflows on the left pane. Currently, I have three available:

I would therefore point you to the latest documentation-generation workflow for the corrected documentation.

https://github.com/bSI-InfraRoom/IFC-Specification/actions/runs/1144296658

I hope you do not see the process as too complex as with formal releases we need some formal approvals. Please feel free to give us feedback on the process as well. This would be much appreciated.

RickBrice commented 3 years ago

Thanks for the clarification. The confusion was my lack of understanding of the workflow.