search

bSI-InfraRoom / IFC-Specification

IfcDoc baseline to produce the documentation
26 stars 25 forks source link

RC4_Update pset issues #326

Open aothms opened 2 years ago

aothms commented 2 years ago

When going over the RC4_Update psets I found the following issues:

  1. No SingleValue DataType: Pset_CivilElementCommon.Reference
  2. No SingleValue DataType: Pset_ElementAssemblyCommon.Reference
  3. No SingleValue DataType: Pset_FurnitureTypeCommon.Reference
  4. No SingleValue DataType: Pset_RampCommon.LoadBearing
  5. No SingleValue DataType: Pset_RampCommon.ThermalTransmittance
  6. No SingleValue DataType: Pset_RoadMarkingCommon.MaterialColour
  7. No SingleValue DataType: Pset_RoofCommon.LoadBearing
  8. No SingleValue DataType: Pset_SpatialZoneCommon.Reference
  9. No SingleValue DataType: Pset_StairCommon.LoadBearing
  10. No SingleValue DataType: Pset_StairCommon.ThermalTransmittance
  11. No templatetype: Pset_BoreholeCommon
  12. No templatetype: Pset_BridgeCommon
  13. No templatetype: Pset_CivilElementCommon
  14. No templatetype: Pset_ElementAssemblyCommon
  15. No templatetype: Pset_GeotechnicalAssemblyCommon
  16. No templatetype: Pset_GeotechnicalStratumCommon
  17. No templatetype: Pset_LinearReferencingMethod
  18. No templatetype: Pset_MaintenanceStrategy
  19. No templatetype: Pset_MarineFacilityTransportation
  20. No templatetype: Pset_MarkingLinesCommon
  21. No templatetype: Pset_MobileTelecommunicationsApplianceTypeCommon
  22. No templatetype: Pset_PavementCommon
  23. No templatetype: Pset_PlantCommon
  24. No templatetype: Pset_ReferentCommon
  25. No templatetype: Pset_RoadGuardElement
  26. No templatetype: Pset_RoadMarkingCommon
  27. No templatetype: Pset_RoadSymbolsCommon
  28. No templatetype: Pset_SensorTypeFrostSensor
  29. No templatetype: Pset_SensorTypeIdentifierSensor
  30. No templatetype: Pset_SolidStratumCapacity
  31. No templatetype: Pset_SolidStratumComposition
  32. No templatetype: Pset_SpatialZoneCommon
  33. No templatetype: Pset_Stationing
  34. No templatetype: Pset_SumpBusterCommon
  35. No templatetype: Pset_TrafficCalmingDeviceCommon
  36. No templatetype: Pset_Uncertainty
  37. No templatetype: Pset_WaterStratumCommon
  38. Templatetype QTO_TYPEDRIVENOVERRIDE: Pset_MarineVehicleCommon

So 3 categories of issues:

SergejMuhic commented 2 years ago

Thank you @aothms! The new properties are in three batches (Road, P&W and Rail). We need to fix those. We are not mandated to fix the old ones though. As a matter of fact we were told not to touch them. Road and P&W were not properly QAed and many were added manually to the spec. For Rail we have a review process and some automatic checks and type assignments, so these should be much better.

Regarding template types, I am not sure that that is an error since the attribute is optional. @TLiebich @MatthiasWeise IfcPropertySetTemplate.TemplateType is optional, should we always set it anyway?

On some of the issues: to 1. Not sure what to do with this one as IfcCivilElement is deprecated. Probably deprecate the Pset also? to 2. -5. Old issues. to 6. @larswik our responsibility to 7. -10. old to 38. This is interesting. It is a valid type and it is also assigned to both IfcTransportElement and IfcTransportElementType. @AlexBrad1ey can give us the best explanation and background.

  • Should MaterialColour be a reference property to a IfcColourRGB instead?

I do not see IfcColourRGBin the IfcObjectReferenceSelect. Would we want to add this? Perhaps this is the reason that the PrimaryDataType was not assigned. @larswik would know more.

On the TemplateTypes I would like to hear from @TLiebich and @MatthiasWeise.

And the last point I would as @AlexBrad1ey @AlexBrad1eyCT (just referencing both, not sure which one is active 😄 ).

SergejMuhic commented 2 years ago

I would also use this issue to point out a couple more. Forgot a couple of times now to post these:

  1. https://github.com/bSI-InfraRoom/IFC-Specification/tree/develop/IFC4x3/Properties/h/HydraulicConductivity_0n5hy7wA9CGeRruzAkgVAG and https://github.com/bSI-InfraRoom/IFC-Specification/tree/develop/IFC4x3/Properties/p/PwaveVelocity_25QNLFrcX23AOU3hgpu9do also https://github.com/bSI-InfraRoom/IFC-Specification/blob/develop/IFC4x3/Properties/s/SwaveVelocity_0Zt9yzVWjF3QUsVuryk8eT/DocProperty.xml should be IfcLinearVelocityMeasure
  2. https://github.com/bSI-InfraRoom/IFC-Specification/tree/develop/IFC4x3/Properties/l/LoadbearingCapacity_2r2w0IRgj2ZPPZHhlnoADU maybe a typo in the name and the PrimaryDataType should be IfcPressureMeasure
aothms commented 2 years ago

Thanks for the quick and detailed reply @SergejMuhic :)

Let's await responses from the others.

Good point about the IfcObjectReferenceSelect. I hadn't thought of that. Probably anyway reference properties aren't that well supported in software, so maybe it's better to stick to simple/enum value.

Quickly going over them. Current properties re colour are not very consistent, they are either IfcText IfcLabel or PEnum_CoreColorsEnum (BLACK BLUE BROWN GOLD GREEN GREENANDYELLOW GREY NOTKNOWN ORANGE OTHER PINK RED SILVER TURQUOISE UNSET VIOLET WHITE YELLOW) and a specific one for sprinklers.

Not sure what is wise here. PropertyListValue<IfcNormalizedRatioMeasure> is an option, but it seems like users probably want to (also..) be able to specify named colors. The current enum is a bit odd (no purple?), https://en.wikipedia.org/wiki/Web_colors#HTML_color_names has some ideas.

cc @berlotti because a consistent representation of colours touches upon prop normalization

AlexBrad1eyCT commented 2 years ago

I will look in to these this week, thanks for picking this up detailed response to follow.

AlexBrad1eyCT commented 2 years ago

P&W - See #337

Shared Infra - See #338

Road - See #339

Rail

To be completed after Property Set Work Finishes

Legacy - See #340