bTayFla / PtTracker

A ProfitTrailer addon that uses PT data files to automatically track your daily and monthly profits in real time.
80 stars 2 forks source link

profits displaying incorrectly #92

Closed bowechaim closed 6 years ago

bowechaim commented 6 years ago

the profits display within the gui are inconsistent with profit trailer.

the profit %'s line up and are the same as pt.

please see uploaded screen captures.

profit-trailer-profits pttracker-profits

LiamAird commented 6 years ago

Profit Trailer is always showing the current price value for your profits. Tracker is showing the value of the closing price of the base pair, giving you a better indication of what you earned that day.

bowechaim commented 6 years ago

thanks for the update.

I hear what you are saying, however, that does not make sense. 1) profits are a closed transaction in time. why would you have pt tracker display the current value?? 2) can you clarify what you mean by the "value of the closing price of the base pair"?

LiamAird commented 6 years ago

When you sell off a pair you make x crypto (y $). We monitor what the dollar value was at the time of the sell, instead of always making it fluctuate with the current standard. So if you sold off a pair, when BTC was at 7.000$ it would record that, if you sold another at 8.500$ it would show that value. Both of these will not go up and down because, at the time of the sell, the price was at certain state.

The way PT is showing it is to always show the sales at the current value - which makes very little sense tbh.

bowechaim commented 6 years ago

again, understood. thanks for the clarification. Profit trailer works the same. once the transaction is closed, profit trailer reports the profits. when i look in my sales log within profit trailer, those profits are hard recorded, they do not change with the market price changes.

bowechaim commented 6 years ago

so i still do not see the difference with profit trailer and pt tracker.

LiamAird commented 6 years ago

They are not in PT. If you keep an eye on the sales log (or any log for that matter) the USD profit will change, once the prices changes. I just double checked, and it does change.

bowechaim commented 6 years ago

the price fluctuates, however, the profits do not. please review again. i have been staring at my sales log now for 5 minutes and there is no change, it is static. all other queues - like pairs log, dca log are dynamic and numbers are changing there.

LiamAird commented 6 years ago

Profits do not, no. However the USD price in PT fluctuates (sales log: https://www.screencast.com/t/jYN2dmA4G), whenever the base currency changes price.

We track what you earned in the moment of the sale.

bowechaim commented 6 years ago

k, i now have seen my profits change. that is ridiculous that profit trailer does that, however, i understand why they would choose to do it like that. thanks for your time and patience.