Closed msynk closed 1 year ago
I think the issue is coming from this line:
and the fact that the CascadingParameterAttribute
now has a base class named CascadingParameterAttributeBase
in .NET 8 RC 2
Hmm interesting. Wonder why our own tests haven't caught this. Can you provide an example of a test that causes this. Should be a pretty easy fix though, so we should be able to get a fix out soon.
Even with the new introduction of the new base class, that shouldn't much interfere with the usage.
As @egil mentioned, it would be really helpful to have a minimal reproducible example for us. We have many tests in combination with cascading parameters and not of them experienced such an exception.
here is the sample repo: https://github.com/msynk/bUnitNet8RC2
It seems this exception throws only for the components with parameters.
Interesting - the same test passes when moved inside our test suite.
@linkdotnet really interesting. I've run the tests in both stable and preview versions of bUnit (1.23.9, 1.24.3-preview) with the same results.
Sorry - I meant I moved the test inside the bUnit code and let it run there. No issue at all. Even if I check out 1.23.9
and let the test run.
Is it a mstest thing?
Thought so too and "migrated" the given example to xUnit with the same outcome - still failing tests with the given exception.
With 1.22
(where we don't explicitly support net8.0
) it works like a charm (which makes sense given the context).
Doing a new preview release now that will build against RC2. Perhaps that fixes the issue. Guessing the package on nuget.org is build against rc1 and that is causing the failure. We cannot replicate when adding the tests and running against bunit sources.
Ah fair - I also run rc.2 locally. But that bit is anyway interesting. Why should it fail with a type that is provided by the framework and not us.
Upgrading to <PackageReference Include="bunit" Version="1.24.8-preview" />
fixes the problem for me.
Ah fair - I also run rc.2 locally. But that bit is anyway interesting. Why should it fail with a type that is provided by the framework and not us.
Guessing it is because rc1 and rc2 are not binary compatible.
Okay - @msynk can you confirm that it also works on your side?
@linkdotnet Thanks a lot. the latest preview version (1.24.9-preview) is working fine for me 👏.
Nice!
after updating to .NET 8 RC 2 our tests fail with the following exception:
Stack trace: