Closed Qwertyluk closed 2 months ago
Hey @Qwertyluk - thank you for the PR. The change itself looks good. I have two small amendments:
CHANGELOG.md
? Under the Unreleased
section add another Added
with a small text crediting you (I guess you will get the gist if you read some others).If you just update the changelog like Steven says, then our deployment will add the correct version tag next to it.
I've updated the changelog.
Though I haven't touched the documentation as I'm not sure if these changes are significant enough to require documentation updates.
There was already an overloaded method ComponentParameterCollectionBuilder.Add
that supports asynchronous callbacks and accepts Func<Task>
. In this PR, I only added the ability to pass arguments for async callbacks so I have a feeling that mentioning these overloads might unnecessarily complicate the documentation.
However, if you believe the documentation should be updated to include the support for asynchronous callback parameters, let me know and I'll make the necessary updates.
Sorry for the delay. LGTM. Will run CI
Closes #751
note: I haven't updated CHANGELOG.md because I couldn't find an appropriate section for the changes for v2.
PR meta checklist
main
branch for codeor targeted at
stable
branch for documentation that is live on bunit.dev.Code PR specific checklist