Closed nitish1295 closed 1 year ago
Awesome!
I'll update torch/black in a PR separately.
My only comment would be around the csvs. Could we load the dataset directly from HuggingFace? load_datasets('tweet_eval", "emotion")
?
Also if you can, could you add the new notebook to the documentation in mkdocs.yml
? Maybe make a new subsection to hold all tutorials for production.
Very minor comments! Thank you very much.
My only comment would be around the csvs. Could we load the dataset directly from HuggingFace? load_datasets('tweet_eval", "emotion")?
I had expected this but I had deliberately done this to "mimic" a setting where we do not load data directly via Hugging Face, but I guess people can do this on their own based on their requirements. Will update this.
Yes will do the docs thing
Summary:
This is a demo/tutorial to use active learning with hugging face models in a production setting. Kindly find more about this at in the discussion at https://github.com/baal-org/baal/discussions/242
Features:
NA
Checklist:
tests/documentation_test.py
).Given that this is a notebook and I am not setting up any new modules there are no test cases. There is some pending type hinting pending which I will complete.
Opening a PR for your feedback, just to check if you want me to add/remove somethings
Additional Info
Challenges with current GPU
Seems like the pytorch version which baal uses does not support my current GPU. Although I have tested this on Colab and it works fine.
More info about this on the pytorch forum in case someone runs into a similar issue
Although I have tested this on Colab and it works fine.
Challenges with Black Formatting
You might want to update your black version to
black==22.3.0
.The make format command produces an error which is identical to the one mentioned at stack overflow here.
I have encountered this before and an upgrade does fix it