Send content-length header in method responses

baalexander / node-xmlrpc

A pure JavaScript XML-RPC client and server for Node.js.

MIT License

295 stars 150 forks source link

Send content-length header in method responses #132

Open chfritz opened 8 years ago

chfritz commented 8 years ago

unlike method calls (client), method responses (server) did not yet send content-length headers. This was causing problem with at least one client (ros's turtlesim, in the context of rosnodejs: publishing to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes that.

atn18 commented 5 years ago

Hi, there! Are there any stop factors for merging this PR?

rudicus commented 4 years ago

@agladkov We would love to see this patch pushed. Are there any actual objections?

atn18 commented 4 years ago

I have no objections. I have not merge perms :) Question to @baalexander

rudicus commented 4 years ago

@baalexander @patricklodder Any chance you guys can merge this and update the published npm package? We are dependent on a downstream package (https://www.npmjs.com/package/rosnodejs) and I would hate to have to fork both projects for a 1 line change. Thanks.

cr1979 commented 1 year ago

I need that change as well!

chfritz commented 1 year ago

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

cr1979 commented 1 year ago

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

@chfritz perfect thank you!