search

baalexander / rosnodejs

A ROS client library using node.js
http://baalexander.github.com/rosnodejs/
MIT License
36 stars 8 forks source link

0.1.0 wip - fix MD5 #25

Closed maxired closed 12 years ago

maxired commented 12 years ago

Hi @baalexander, here a pull request for https://github.com/baalexander/rosnodejs/issues/24

It fix the MD5 computation of files and added some test. It seems to be working well. Maybe i will imporve it, but I wanted to provide you very quickly a first version.

One things that I noticed during the implentation, is that others implementations tends to have a message.field for every dynamic field and message.contants for constancts. We probably also should do it this way.

Moreover, I found it annoying that the helper functions in libMessages.js are not linked to the object that we are building. So it is difficult to share a context and lots of things has to be shared within the paramters. I don't think this is a good things.

maxired commented 12 years ago

sorry for this one, I targeted a bad branch