Updating the certificate object in the template to include full date value in duration attribute

baarde / cert-manager-webhook-ovh

OVH Webhook for Cert Manager

Apache License 2.0

93 stars 62 forks source link

Updating the certificate object in the template to include full date value in duration attribute #25

Closed TheMrPuffin closed 1 year ago

TheMrPuffin commented 1 year ago

When using ArgoCD to deploy cert-manager-webhook-ovh the certificate objects for the OVH CA and TLS are always out of sync. This due to mismatch between the duration declared by the helm template and the certificate object that is created.

I have updated the template objects to reflect what the value would be when the certificate objects is created.

aureq commented 1 year ago

@TheMrPuffin You may want to have a look at https://github.com/aureq/cert-manager-webhook-ovh/ since this project doesn't appear to maintained.

Also, the changes you're proposing here are already integrated my my fork. However, it would be great if you could comment on this PR please https://github.com/aureq/cert-manager-webhook-ovh/pull/10