baaron4 / GW2-Elite-Insights-Parser

Binary parser for the .evtc files that arcdps generates after a boss encounter. This will generate a .html file where the results can be easily reviewed.
MIT License
130 stars 47 forks source link

Golem: Average Condition uptime not showing on some logs #57

Closed Quadellupine closed 6 years ago

Quadellupine commented 6 years ago

Hey!

In an attempt to minmax confusion uptime and DPS on mirage, we used your tool to parse golem logs. They usually showed the amount of stacks of confusion the golem had on average. However, in the actual benchmark log (lol) this function randomly stopped working. The damage is also much lower than normal. The ingame meter shower ~34k as endnumber, the log only shows 27.

Links to the bugged HTMLs and evtc (github wont let me upload): https://cdn.discordapp.com/attachments/409691829311635457/460087331290873856/buggedconfusionhtml.html 460084805175083010

Link to a normal log for reference: https://cdn.discordapp.com/attachments/409691829311635457/460087362056093696/20180623-155523.evtc.zip https://cdn.discordapp.com/attachments/409691829311635457/460087666092933150/20180623-155523.evtc.zip__fail.html

I'm not sure if this issue is arc or parser related, hence why I wanted to make that post and ask.

EliphasNUIT commented 6 years ago

This does not look like a confusion bug, in the bugued log Tolgon does not have any power damage xD Let me take a look

EliphasNUIT commented 6 years ago

Which version did you use? A previous version had issues. This is what I'm getting in my branch: test2 test3

Edit: This does not happen with 1.3 either

baaron4 commented 6 years ago

That file name ending in .evtc.zip__fail.html makes me think this is indeed a older version of EI

Quadellupine commented 6 years ago

I didn't update to the version released 13h ago, for some reason I didn't get a notifcation. The part that was weird to me was that all other (And it were many) previous golem logs worked, just not this one in particular.

Quadellupine commented 6 years ago

Update, parsing it with the updated version causes the command line to throw errors and close before I can read them. It also errors "while performing background operations" if I open it in the exe. image image

Am I just dumb?

EliphasNUIT commented 6 years ago

I'll fix that ASAP, we had a major rework as to how the application works, that must be the cause.

Edit: No scratch that, looks different Can you send the log please? I remember this issue should have been fixed sometimes ago

Quadellupine commented 6 years ago

https://cdn.discordapp.com/attachments/409691829311635457/460084805175083008/20180623-161059.evtc.zip

This is the bugged log I tried to parse

EliphasNUIT commented 6 years ago

This is a golem right? seems like there is a regression on its death time, apparently you have been fighting it for 292471208 years. The application did not like that. Investigating

Quadellupine commented 6 years ago

He did say it felt like it took that long lol

EliphasNUIT commented 6 years ago

Was there an issue during the logging process? I'm seeing stuff that shouldn't be possible:

I've fixed the issue of the golem not beeing properly detected, however as I said, there are two golems in the logs, this could be an Arc related issue

Tolgon commented 6 years ago

Here is the video of the whole fight. https://www.youtube.com/watch?v=YSO3_dXm4EI

EliphasNUIT commented 6 years ago

100% Arc dps issue, if you check your vid you can see that you are at 27Kish boss dps and 33Kish total dps

That would explain why at first GW2El did not detect the golem, to fix the detection I had to change the detection algorithm Delta advises to use at https://www.deltaconnected.com/arcdps/evtc/README.txt .

I'm not sure if I should push that fix now.

Quadellupine commented 6 years ago

Not sure, as in it might break something else?

EliphasNUIT commented 6 years ago

Yes, because it is kinda hacky ^^ And even if I did you'd never get all the data you'd like to, it is impossible to properly detect applied conditions in this log. Also, this situation is completely random, does not happen on every golem log, I believe this should be put into Delta's attention.

Edit: I'll try to come up with a "cleaner" hack in case nothing can be done on Delta's side

EliphasNUIT commented 6 years ago

Good news, I have something but I don't know how robust it is. At least it can't break anything outside of golems

EliphasNUIT commented 6 years ago

There you go: t1 t2

Quadellupine commented 6 years ago

Thank you very much! I'll message delta about this issue later I guess.

EliphasNUIT commented 6 years ago

I think we'll do another quick release soon. Please don't hesitate to come back if you see golem issues, i'm really not convinced that the hack covers everything ^^

Send them to me through Discord and I'll "complete" the hack ASAP

baaron4 commented 6 years ago

You can always send files over Github just have to .zip them first.

EliphasNUIT commented 6 years ago

Damnit Baaron, I'm trying to attract people to GW2EI discord here! =D

EliphasNUIT commented 6 years ago

Should be definitively fixed in next release. If not please re-open an issue =D