search

baato / before-after

Generate before-after maps for OpenStreetMap with ease.
https://beforeafter.baato.io/
21 stars 2 forks source link

Use colon in name cause this project can't be clone under Windows #47

Closed LaoshuBaby closed 6 months ago

LaoshuBaby commented 6 months ago

Describe the bug

The file named "logo.png:Zone.Identifier" will cause checkout failed on Windows.

annoy-colon

To Reproduce

  1. Find a computer running Windows and installed with Git
  2. Run git clone https://github.com/baato/before-after.git on somewhere you can access.
  3. Wait for the error

Expected behavior

Clone and generated all files in this branch when checkout.

Screenshots

a-null-blackhole

Desktop (please complete the following information):

Additional context

Colon is a reserved character in Windows according to MS's document. Although many of your developer are using MacOS or some Linux distribution, use such a symbol that can cause error and unstable isn't a good idea I guess. And I've searched this "logo.png:Zone.Identifier" name via GitHub's webpage, found 0 time it was referenced, only found 4 time have a "logo.png"

referenced-places

LaoshuBaby commented 6 months ago

Why opened this issue:

图片

Because I want to try self-host a instance to generate some tiles, perhaps it was closed due to cost-saving measures since there weren't many people using it online? In any case, we should thank Baato for keeping this repository.

drklrd commented 6 months ago

Hi @LaoshuBaby,

I have removed the unwanted Zone identifier file (that was an unintentional push, I think). The clone should work now.

The online service is still available. As this is hosted on a shared space, it might have been unable to generate new maps because of storage. But it should work now.

Thank you for bringing this issue to light.