Open imaginator opened 5 years ago
Hmm yes. UNDEF is basically hard to display. What would be the right thing to do with the metric when it’s not defined? Simply leaving it out of the output is my first thought about this. Pretty sure that using a pre-defined number would be wrong.
I agree with you - leave out.
I sent you a PR to just leave it out as I see you are already doing with null values.
On Tue, 14 May 2019, 21:06 Leroy Förster, notifications@github.com wrote:
Hmm yes. UNDEF is basically hard to display. What would be the right thing to do with the metric when it’s not defined? Simply leaving it out of the output is my first thought about this. Pretty sure that using a pre-defined number would be wrong.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/baaym/openhab2-prometheus-exporter/issues/1?email_source=notifications&email_token=AADSURFV732SND6XLT2E2XDPVMETDA5CNFSM4HMYQKG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMPG5Y#issuecomment-492368759, or mute the thread https://github.com/notifications/unsubscribe-auth/AADSURHEE23SYAXN7SDLDYDPVMETDANCNFSM4HMYQKGQ .
This is exactly what I was looking for. Thanks.
Small issue: some of my values are
UNDEF
:Which leads to this: