search

bab2min / EigenRand

Fastest Random Distribution Generator for Eigen
https://bab2min.github.io/eigenrand/
MIT License
92 stars 13 forks source link

Add EIGENRAND_BUILD_BENCHMARK cmake option #55

Closed jorisv closed 11 months ago

jorisv commented 11 months ago

Hello @bab2min,

Here a PR to turn benchmark building optional. Today, when using EigenRand as a submodule or with FetchContent, EigenRand benchmark are added to the main project test. With this PR, we can disable them, and avoid running it.

Thanks !

ManifoldFR commented 11 months ago

Seems there's an #include <cstdio> missing and the build step actually fails (but the CI reports a success) @bab2min

jorisv commented 11 months ago

Hello @bab2min,

All the checks are green except the one on Windows avx512. I think the Windows agent doesn't support avx512 and then can't run the unit test.

bab2min commented 11 months ago

@jorisv Yes, I think so. It seems to be an error in the CPU running unit test, not an error in the code. Looks good to me. Thank you for your useful and meaningful contribution. @ManifoldFR

ManifoldFR commented 11 months ago

Thank you @bab2min !

I didn't forget my issue #53 on adding PDFs/CDFs to the library, sadly I've been sidetracked the past few months so I don't have a PR for that yet but I hope to clear time for that soon.