babarot / enhancd

:rocket: A next-generation cd command with your interactive filter
2.58k stars 109 forks source link

Error while entering a directory from a directory with spaces on the name #222

Open Dominiquini opened 11 months ago

Dominiquini commented 11 months ago

What did you expect to happen? The terminal should behave normally and the 'enhancd' should log the new visited PATH

What actually happened? A error is printed on the terminal:

Output

find: ‘/home/rafaeldominiquini/Documents/Projects/ZZZ’: No such file or directory
find: ‘-’: No such file or directory
find: ‘Others’: No such file or directory

Additional context 1) Delete enhancd.log (The bug only happens the first time the directory is visited!) 2) Create a dir "/home/username/dir with space/destination" 3) Navigate to the dir "dir with space": cd /home/username/dir\ with\ space 4) Navigate to "destination": cd destination 5) Error is printed on the terminal

Some debug with set -x:

...
+++++ for dir in "${dirs[@]}"
+++++ command find '/home/rafaeldominiquini/Documents/Projects/ZZZ - Others/ugrep' -maxdepth 1 -type d -name '\.*' -prune -o -type d -print
+++++ for dir in "${dirs[@]}"
+++++ command find /home/rafaeldominiquini/Documents/Projects/ZZZ -maxdepth 1 -type d -name '\.*' -prune -o -type d -print
find: ‘/home/rafaeldominiquini/Documents/Projects/ZZZ’: No such file or directory
+++++ for dir in "${dirs[@]}"
+++++ command find - -maxdepth 1 -type d -name '\.*' -prune -o -type d -print
find: ‘-’: No such file or directory
+++++ for dir in "${dirs[@]}"
+++++ command find Others -maxdepth 1 -type d -name '\.*' -prune -o -type d -print
find: ‘Others’: No such file or directory
...

The bug is on the file 'filepath.sh' on the line 22!

Testing on BASH in Ubuntu 22.04 (WSL2 under Windows 10) App version: "master"

Thanks

Dominiquini commented 11 months ago

I was able to fix this bug:

fix.patch

Take a look if this don't break anything!

Thanks.

jeebak commented 5 months ago

I was able to fix this bug:

fix.patch

Take a look if this don't break anything!

Thanks.

Ah, nice! This seems to work too:

diff --git a/src/filepath.sh b/src/filepath.sh
index e62b08c..1a3ec4c 100644
--- a/src/filepath.sh
+++ b/src/filepath.sh
@@ -15,7 +15,7 @@ __enhancd::filepath::walk()

   # __enhancd::filepath::get_parent_dirs does not return $PWD itself,
   # so add it to the array explicitly
-  dirs=( "${PWD}" $(__enhancd::filepath::get_parent_dirs "${1:-${PWD}}") )
+  IFS=$'\n' dirs=( "${PWD}" $(__enhancd::filepath::get_parent_dirs "${1:-${PWD}}") )

   for dir in "${dirs[@]}"
   do

Either shouldn't break anything, IMHO.