search

babashka / babashka-sql-pods

Babashka pods for SQL databases
Eclipse Public License 1.0
85 stars 16 forks source link

Add MSSQL Support #23

Closed jvtrigueros closed 3 years ago

jvtrigueros commented 3 years ago

I'm attempting to add support for mssql, I'm not super familiar with what flags are needed for GraalVM support, but I gave it my best shot.

I needed to modify the compilation flags quite a bit to get this to compile natively. In the end, it does work, but I'm sure there are probably some issues with my approach.

borkdude commented 3 years ago

Thanks a lot @jvtrigueros !

borkdude commented 3 years ago

@jvtrigueros It seems the PR broke the builds

https://app.circleci.com/pipelines/github/babashka/babashka-sql-pods/130/workflows/a1d716b0-88e7-4226-9771-aa56aca5924c/jobs/533

Maybe make (some of the) mssql settings depend on the env variable.

jvtrigueros commented 3 years ago

Oh no! I'll submit another PR. I'll see if I can set up CircleCI on my fork to ensure that the build is still working.

borkdude commented 3 years ago

@jvtrigueros Normally PRs should be built also on this project, so maybe try that first. I don't know why your first PR didn't have this problem.

borkdude commented 3 years ago

@jvtrigueros Already fixed.

jvtrigueros commented 3 years ago

@borkdude you're the best! Would you still like me to submit a PR adding the extra stuff on the .circleci config files? I don't think the binary is being built at the moment.

borkdude commented 3 years ago

@jvtrigueros Yeah, please do that. I'm not sure if we are allowed to distribute binaries for MSSQL though in the pod-registry? What's the license on that thing?

jvtrigueros commented 3 years ago

I'll have to check, but I'll get back to you on that.

jvtrigueros commented 3 years ago

Ok, it seems like microsoft/mssql-jdbc is licensed under MIT, so we should be good to redistribute! 🙌

borkdude commented 3 years ago

That's good news. So feel free to PR the CircleCI config and we can start distributing it via the pod registry.