babashka / babashka-sql-pods

Babashka pods for SQL databases
Eclipse Public License 1.0
85 stars 17 forks source link

Update Circle CI Config for MSSQL Binaries #24

Closed jvtrigueros closed 3 years ago

jvtrigueros commented 3 years ago

~I've added the build jobs for mssql. I'm not sure if Circle CI supports anchors, but this eliminates the need to keep copy pasting. If it's a preference thing, I'll expand the anchors in their respective location.~

Correctly updating generate_circleci.yml.

borkdude commented 3 years ago

You should be editing the config generation script, not the config itself :)

https://github.com/babashka/babashka-sql-pods/blob/be16de288640e60a5b48857d8b6a5c66b96de4e0/.circleci/config.yml#L1

jvtrigueros commented 3 years ago

🤦‍♂️ I’ll try again, sorry for the churn 😅


From: Michiel Borkent notifications@github.com Sent: Friday, February 19, 2021 12:15:12 AM To: babashka/babashka-sql-pods babashka-sql-pods@noreply.github.com Cc: Jose V. Trigueros j.v.trigueros@gmail.com; Author author@noreply.github.com Subject: Re: [babashka/babashka-sql-pods] Update Circle CI Config for MSSQL Binaries (#24)

You should be editing the config generation script, not the config itself :)

https://github.com/babashka/babashka-sql-pods/blob/be16de288640e60a5b48857d8b6a5c66b96de4e0/.circleci/config.yml#L1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/babashka/babashka-sql-pods/pull/24#issuecomment-781912129, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABFA2HMTBMY4MALNNU4Q5DS7YMZBANCNFSM4X3NWNYQ.

jvtrigueros commented 3 years ago

generate_circleci.yml is so much easier!

borkdude commented 3 years ago

@jvtrigueros Can you rebase/merge with master?

borkdude commented 3 years ago

Thanks!

borkdude commented 3 years ago

@jvtrigueros I now added the mssql pods to the release here:

https://github.com/babashka/babashka-sql-pods/releases/tag/v0.0.2

Feel free to update the pod registry for the mssql pod as well.