search

babashka / babashka-sql-pods

Babashka pods for SQL databases
Eclipse Public License 1.0
85 stars 16 forks source link

MySQL datetime handling #41

Closed john-shaffer closed 3 years ago

john-shaffer commented 3 years ago

Currently we get an exception when the MySQL driver returns a LocalDateTime. This handles LocalDateTimes correctly and adds tests against now() and the date, datetime, and timestamp types.

I decided not to implement any JSON conversions because the driver returns JSON as strings rather than JSON objects like the postgres driver does, so we can't convert them automatically. I recommend calling the JSON generation and parsing functions manually when using MySQL.

Closes #8.

borkdude commented 3 years ago

@john-shaffer Hey John, I already have some fixes for that on master, but this requires a new babashka version as well from master.

borkdude commented 3 years ago

@john-shaffer If you are in a hurry, I can do releases of both.

borkdude commented 3 years ago

Your tests do seem to be more extensive. You can make a PR with only your tests and they should already work on CI.

borkdude commented 3 years ago

I'll just merge your PR for now so it works with older version of bb as well.