bb should error when bb.edn does not contain exactly one valid form

babashka / babashka

Native, fast starting Clojure interpreter for scripting

https://babashka.org

Eclipse Public License 1.0

4.03k stars 247 forks source link

bb should error when bb.edn does not contain exactly one valid form #1691

Open ingydotnet opened 5 months ago

ingydotnet commented 5 months ago

See this thread https://clojurians.slack.com/archives/CLX41ASCS/p1715005486373559

borkdude commented 5 months ago

Can you include the information about the TDEPS issue here?

ingydotnet commented 5 months ago

athos 1 day ago I originally reported this issue for tools.deps at TDEPS-73, but I didn’t take care about -Sdeps back then, so I think probably there is no particular reason it shouldn’t be fixed for -Sdeps.

bobisageek commented 4 months ago

Based on #1652 , maybe the requirement should be 'zero or one valid forms', or 'empty or exactly one valid form' to avoid a regression.

borkdude commented 4 months ago

Good observation.