@bobisageek @rads This fixes two problems I noticed when installing and using bbin on Windows.
I noticed the arguments to exec, usually a string of vectors, was passed as multiple arguments that were put back using a string again. In some cases this can result in strange behaviors, so let's just keep the arguments separate using the idiom (into [] ..) rather than (str/join " " (concat ...)).
Another thing I noticed is that the maven dep script had a dangling quote. This did not cause any errors, because the exec call replaces the parent process before it could cause any errors, but I think it would be cleaner to remove it.
Another thing: my editor indents single ; weird, so I made double ;; from them.
Another thing: there was quite some dangling whitespace, which I removed using my editor.
Also I ran lsp-organize-imports to sort namespace requires.
@bobisageek @rads This fixes two problems I noticed when installing and using bbin on Windows.
I noticed the arguments to
exec
, usually a string of vectors, was passed as multiple arguments that were put back using a string again. In some cases this can result in strange behaviors, so let's just keep the arguments separate using the idiom(into [] ..)
rather than(str/join " " (concat ...))
.Another thing I noticed is that the maven dep script had a dangling quote. This did not cause any errors, because the
exec
call replaces the parent process before it could cause any errors, but I think it would be cleaner to remove it.Another thing: my editor indents single
;
weird, so I made double;;
from them.Another thing: there was quite some dangling whitespace, which I removed using my editor.
Also I ran
lsp-organize-imports
to sort namespace requires.