search

babashka / bbin

Install any Babashka script or project with one command
MIT License
139 stars 9 forks source link

support local installs on Windows #38

Closed bobisageek closed 2 years ago

bobisageek commented 2 years ago

Please answer the following questions and leave the below in as part of your PR.

Basically, this change uses fs functions to compute the script name to be more OS-agnostic. As noted on the issue, there's technically a change in behavior here, in that script names with multiple dots would be named everything up to the last dot (as opposed to everything up to the first dot), so installing 'hello.foobar.clj' would install by default as 'hello.foobar' instead of 'hello'. This seems like a corner case given clj file/namespace naming conventions.

rads commented 2 years ago

Thanks for the PR! I’m out of town this week but I should have a chance to look at this next week.