search

babashka / bbin

Install any Babashka script or project with one command
MIT License
138 stars 9 forks source link

bbin install [LOCAL-FILE] should not be restricted to files with the .clj extension #72

Closed mtwomey closed 6 months ago

mtwomey commented 1 year ago

It would be preferable if you could install local scripts not ending in .clj using bbin install.

For example, I personally prefer to name my babashka scripts with the .bb extension to differentiate them.

rads commented 1 year ago

Thanks for the bug report. I can go ahead and add the .bb extension no problem.

As for installing any file extension, I need to think about this some more given that we're using the file extension for other use cases, such as .jar files.

borkdude commented 1 year ago

To me it makes sense to treat any extension as a bb script, unless it's a specific extension like .jar

borkdude commented 1 year ago

It seems .cljc isn't treated as a script either.

mtwomey commented 1 year ago

@rads Thank you, this does solve my issue. I do wonder if @borkdude 's thought about "reversing" the logic so that is treats files as bb scripts by default (with specific exceptions) might have more utility in the long run?

rads commented 1 year ago

Makes sense. I reopened this issue and will follow up with some more changes later.

borkdude commented 7 months ago

Since @rads doesn't maintain this tool anymore (or soon-ish) and this issue hit some other person as well recently, I'll have a look at this issue soon-ish, hopefully.

rads commented 6 months ago

This is now fixed in 0.2.3 (any extension can be used).

borkdude commented 6 months ago

Thanks a lot @rads !