search

babashka / bbin

Install any Babashka script or project with one command
MIT License
139 stars 9 forks source link

`maven-jar-test` breaks when new `org.babashka/http-server` is published #90

Open rads opened 1 month ago

rads commented 1 month ago

I noticed this when I was bringing https://github.com/babashka/bbin/pull/74 up-to-date with main.

To make this test more stable, I think we could set up bbin-test-lib to publish a couple versions to Clojars so the latest published version will only change when we want it to.

(@borkdude: Should we also move bbin-test-lib to the babashka GitHub org?)

borkdude commented 1 month ago

(@borkdude: Should we also move bbin-test-lib to the babashka GitHub org?)

Perhaps it's possible to move this library inside the bbin repo? We can use it with :deps/root

rads commented 1 month ago

For this particular issue with the Maven dependency, we could publish a test JAR from a folder within the bbin repo instead of bbin-test-lib and it wouldn't change anything since the test will pull from Clojars anyways.

My intent with the tests using bbin-test-lib (such as git-dir-test) is to make sure the install commands work with things like public vs private repos, and tags vs no tags. It's meant as an end-to-end test so I think replicating the tests within the same repo might be tricky. Perhaps we should move the bbin-test-lib discussion to a separate issue?

borkdude commented 1 month ago

Perhaps we should move the bbin-test-lib discussion to a separate issue?

sure