search

babashka / fs

File system utility library for Clojure
Eclipse Public License 1.0
174 stars 45 forks source link

Explicitly support `:win-exts` on `which` function #65

Closed lread closed 2 years ago

lread commented 2 years ago

Currently

@borkdude has a comment on :win-exts being unsupported for the which function: https://github.com/babashka/fs/blob/5a6358697088261e1d8ace12d4a05ac92b1cd239/src/babashka/fs.cljc#L780-L787

But...

I actually made use of :win-exts on Etaoin to help me locate .ps1 files.

So...

As requested in the comment, I reached out to borkdude on Slack. To which he responded:

I'm fine with removing the comment and support :win-exts

Next Action

I'll follow up with a PR. Only comment and docstring should change.

borkdude commented 2 years ago

👍