search

babashka / http-server

Serve static assets
MIT License
77 stars 8 forks source link

Adds extra optional argument headers #9

Closed rafaeldelboni closed 1 year ago

rafaeldelboni commented 1 year ago

Closes: https://github.com/babashka/http-server/issues/8 Related to: https://github.com/babashka/http-server/issues/7

rafaeldelboni commented 1 year ago

I don't know if you want me to bump version.edn file as well and sorry for any ugly code :)

borkdude commented 1 year ago

I don't think the test folder requires another .clj-kondo directory

borkdude commented 1 year ago

One problem with the string + split way of doing things on the CLI is that headers can start with colons and these would be parsed as the next option. I think coercing the headers as :edn might make more sense in this case?

rafaeldelboni commented 1 year ago

Sure, makes sense

rafaeldelboni commented 1 year ago

@borkdude could you check if my change makes sense?

borkdude commented 1 year ago

Looks good to me!