bug: babashka/nbb-prismatic-schema `s/set-fn-validation!` isn't working as expected - Githubissues

babashka / nbb

Scripting in Clojure on Node.js using SCI

Eclipse Public License 1.0

854 stars 51 forks source link

bug: babashka/nbb-prismatic-schema `s/set-fn-validation!` isn't working as expected #215

Closed omariosouto closed 1 year ago

omariosouto commented 2 years ago

version

"nbb": "0.5.113"
"@babashka/nbb-prismatic-schema":"0.5.113"
Package JSON File: https://github.com/devsoutinho/app-labs/blob/12174ad4518ec8861b72389224aa58f271b313cb/_servers/webproxy/package.json

platform

Node: v16.13.0
NPM: v8.1.0
Yarn: v1.22.17
MacBook Pro (13-inch, M1, 2020) | Apple M1 | macOS MOnterey Version 12.4

problem

s/set-fn-validation! isn't working as expected

repro

Just download these files in this commit: https://github.com/devsoutinho/app-labs/blob/12174ad4518ec8861b72389224aa58f271b313cb/_servers/webproxy/webproxy/app/diplomat/http_server.cljs#L9

expected behavior

When run (s/set-fn-validation! false) all validations must be disabled
Right now this isn't happening

borkdude commented 1 year ago

We'll address this as part of schema compatibility when loading schema as a library from source