search

babashka / nbb

Scripting in Clojure on Node.js using SCI
Eclipse Public License 1.0
863 stars 52 forks source link

`exists?` missing? #346

Closed martinklepsch closed 8 months ago

martinklepsch commented 8 months ago

version

1.2.182

platform

Mac, Node 21.6.2

problem

----- Error --------------------------------------
Message:  Could not resolve symbol: exists?
Location: ./repro.cljs:1:1
Phase:    analysis

----- Context ------------------------------------
1: (exists? js/process)
   ^--- Could not resolve symbol: exists?

----- Stack trace --------------------------------
user - ./repro.cljs:1:1

repro

echo '(exists? js/process)' > repro.cljs; nbb repro.cljs

expected behavior

exists? is present: https://cljs.github.io/api/cljs.core/existsQMARK

borkdude commented 8 months ago

Thanks, will take a look tomorrow

borkdude commented 8 months ago

Btw, you shouldn't write js/exists?, just exists?

martinklepsch commented 8 months ago

Btw, you shouldn't write js/exists?, just exists?

oh lol, I just messed this up when typing up the issue! sorry!

echo '(exists? js/process)' > repro.cljs; npx nbb repro.cljs
----- Error --------------------------------------
Message:  Could not resolve symbol: exists?
Location: ./repro.cljs:1:1
Phase:    analysis

----- Context ------------------------------------
1: (exists? js/process)
   ^--- Could not resolve symbol: exists?

----- Stack trace --------------------------------
user - ./repro.cljs:1:1

Could not resolve symbol: exists?
martinklepsch commented 8 months ago

Just a reminder that this should maybe be reopened?

borkdude commented 8 months ago

Why, it’s already fixed and published to npm on Monday

https://www.michielborkent.nl https://www.eetvoorjeleven.nu

On Wed, 6 Mar 2024 at 09:23, Martin Klepsch @.***> wrote:

Just a reminder that this should maybe be reopened?

— Reply to this email directly, view it on GitHub https://github.com/babashka/nbb/issues/346#issuecomment-1980318735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFSBTCLORURHFYIFWVTLDYW3HAXAVCNFSM6AAAAABED62L36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBQGMYTQNZTGU . You are receiving this because you modified the open/close state.Message ID: @.***>

martinklepsch commented 8 months ago

Ah damn, sorry! I checked the commits and didn't find anything that looked related, my bad!