babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
367 stars 27 forks source link

Update `add kaocha` version and options #148

Closed KingMob closed 1 year ago

KingMob commented 1 year ago

The neil version is very behind, at 1.0.887, while kaocha is up to 1.76.1230 now.

Also, I think it should also add :main-opts ["-m" "kaocha.runner"] to the :kaocha alias.

Bonus points if it creates bin/kaocha for you, or at least prints out the contents, since the alias name (kaocha) differs from kaocha's suggested alias (test).

borkdude commented 1 year ago

I'm open to a PR that always adds the newest version of kaocha. We're already doing this for tools.build (neil add build). bin/kaocha is a bit too opinionated imo since some project use script, .build, or whatever for their bash scripts and some projects prefer babashka tasks, so I think we should leave that out as it's hard to detect what people want in this area.

KingMob commented 1 year ago

bin/kaocha is a bit too opinionated ...

That's fair, I only suggested it because it was official kaocha documentation, and all the kaocha doc examples assume you've set it up.

borkdude commented 1 year ago

Yes, I think the official kaocha docs are a bit too opinionated here, there is no need to always have this bash script in a specifically named dir.

KingMob commented 1 year ago

I'll leave out the script, but if it's ok, I'll print out what needs to be copied into it, in case the user wants it.

borkdude commented 1 year ago

Sounds good!

On Sun, 29 Jan 2023 at 07:08, Matthew Davidson @.***> wrote:

I'll leave out the script, but if it's ok, I'll print out what needs to be copied into it, in case the user wants it.

— Reply to this email directly, view it on GitHub https://github.com/babashka/neil/issues/148#issuecomment-1407572639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFSBUBGRWFXVBK6TPRZA3WUYCNLANCNFSM6AAAAAAUIL5MSE . You are receiving this because you commented.Message ID: @.***>

-- https://www.michielborkent.nl https://www.eetvoorjeleven.nu