Fix #146: prefer stable versions

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects

MIT License

367 stars 27 forks source link

Closed borkdude closed 1 year ago

borkdude commented 1 year ago

Please answer the following questions and leave the below in as part of your PR.

[x] This PR corresponds to an issue with a clear problem statement: #146 .
[x] I have updated the CHANGELOG.md file with a description of the addressed issue.

borkdude commented 1 year ago

@rads I only implemented this for mvn versions but we could do the same for git tags.

One edge case may be that no version will be found, should we in that case just pick the first version, even if it's alpha?

I also made a test that the version is only upgrade if it's newer than the current version (so current alpha versions will stay in place).

borkdude commented 1 year ago

I'll go ahead and merge this, but feel free to give post-PR comments and we'll change them accordingly.