babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
367 stars 27 forks source link

Remove quoting of Clojars search string #158

Closed tobias closed 1 year ago

tobias commented 1 year ago

I have updated Clojars to convert foo/bar to group-id:foo AND artifact-id:bar (see https://github.com/clojars/clojars-web/issues/856), so the quoting should no longer be necessary (see https://clojars.org/search?q=babashka%2Ffs&format=json as an example). This also updates the search help a bit.

I didn't create a neil issue for this or update the CHANGELOG, but I'm happy to do so if you think it is appropriate.

borkdude commented 1 year ago

@tobias Thanks a lot, I'll make a new release!

tobias commented 1 year ago

@borkdude My pleasure!

borkdude commented 1 year ago

Released as 0.1.53.

Is this expected behavior?

~/dev/neil (main) $ ./neil dep search org.babashka/cli
:lib org.babashka/cli :version 0.6.45 :description "Turn Clojure functions into CLIs!"
~/dev/neil (main) $ ./neil dep search babashka/cli
Unable to find babashka/cli on Clojars.
borkdude commented 1 year ago

According to the tests, this gave at least one result before:

./neil dep search org.clojure/tools.cli

I think it used to find this in one of the descriptions of a library.

tobias commented 1 year ago

Since we're now converting group/artifact to an exact match for group-id:group AND artifact-id:artifact, I would expect the behavior you are seeing. But perhaps it should expand to ((group-id:group AND artifact-id:artifact) OR "group/artifact") to better meet expectations.

On Tue, Jan 31, 2023, at 07:27, Michiel Borkent wrote:

According to the tests, this gave at least one result before:

./neil dep search org.clojure/tools.cli I think it used to find this in one of the descriptions of a library.

— Reply to this email directly, view it on GitHub https://github.com/babashka/neil/pull/158#issuecomment-1410259875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAUR2C2BL7FQ2TZWFLHVLWVEAKLANCNFSM6AAAAAAUMLLD5Q. You are receiving this because you were mentioned.Message ID: @.***>

borkdude commented 1 year ago

If I wanted an exact match every time, then I think I didn't even have to search right?

tobias commented 1 year ago

Hmm, that's a good point. Let's move this discussion back to https://github.com/clojars/clojars-web/issues/856, since I think there is more work to do on the Clojars side.