Closed teodorlu closed 1 year ago
I think this is reasonable. Because of the -X:deps help/doc
only "commands" will get added to this ns and it's very unlikely a new command would be added that isn't another built-in template.
@seancorfield OK! In that case, I'm in favor of merging.
@borkdude does the Clojure code look fine to you? Want any changes?
The print-new-help
implementation got more complex with this PR. I'm open to suggestions, I feel like there's more nesting right now than neccessary, but I don't see any obvious ways to improve it.
One minor comment, the rest looks good to me.
Please answer the following questions and leave the below in as part of your PR.
[ ] This PR corresponds to an issue with a clear problem statement.
[x] I have updated the CHANGELOG.md file with a description of the addressed issue.
Generated helptext
In this PR; the generated helptext is:
$ neil-dev new -h
Should this be merged?
I'm not sure whether this is the way to go to look up valid values template values:
deps-new
could easily add another public var inorg.corfield.new
, and we'll happily assume it's a valid template.Alternatives
165 solves this by linking to upstream documentation.