search

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
374 stars 27 forks source link

Make `:version` consistent over `search` and `dep add` commands #170

Closed dmg46664 closed 1 year ago

dmg46664 commented 1 year ago

The following outputs numbers

neil dep search libpython-clj                                                                             
:lib techascent/tech.jna :version 4.06 :description "Bindings to JNA.  Used with libpython-clj among others."
:lib clj-python/libpython-clj :version 2.024 :description nil
:lib cnuernber/libpython-clj :version 1.36 :description "libpython bindings to the techascent ecosystem"
:lib libpython-clj/libpython-clj :version 1.6-SNAPSHOT :description "libpython bindings to the techascent ecosystem"

However using the command expects strings or it will insert an EDN number which won't work ❗ 

neil dep add :lib clj-python/libpython-clj :version 2.024

So make the latter accept numbers and/or the former output strings.

https://clojurians.slack.com/archives/C03KCV7TM6F/p1677929356870239

borkdude commented 1 year ago

An attempt in the commit above, but it's failing one test. I'd have to check later this week what's wrong.