search

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
367 stars 27 forks source link

neil does not find a newer version of a library that antq does #171

Closed bombaywalla closed 1 year ago

bombaywalla commented 1 year ago

I have an alias :outdated that runs antq. antq finds a newer version of the library that neil dep upgrade does not. Even though they both seem to use version-clj. Admittedly, the name of this library wrt versioning is a bit on strange side. A list of all the versions of this lib on Maven Central is at this link

Below is a small repro example.

dorabs-imac:test dorab$ cat deps.edn
{:paths ["src" "resources"]
 :deps {org.clojure/clojure {:mvn/version "1.11.1"}
        com.google.apis/google-api-services-sheets {:mvn/version "v4-rev20220927-2.0.0"}
        }
}

dorabs-imac:test dorab$ clojure -M:outdated 
[##################################################] 2/2

|    :file |                                      :name |             :current |              :latest |
|----------+--------------------------------------------+----------------------+----------------------|
| deps.edn | com.google.apis/google-api-services-sheets | v4-rev20220927-2.0.0 | v4-rev20221216-2.0.0 |

dorabs-imac:test dorab$ neil dep upgrade --dry-run
dorabs-imac:test dorab$
borkdude commented 1 year ago

The issue is that there is a check for "stable version" which currently is implemented as "any qualifier like -foo indicates a non-stable version". This should probably be fine-tuned, maybe by filtering on "alpha", "beta", etc.

borkdude commented 1 year ago

Should be fixed with 0.1.58