Closed agzam closed 8 months ago
If this is still a work in progress, can you mark the PR as draft? And then ping me for a review when done?
If this is still a work in progress, can you mark the PR as draft? And then ping me for a review when done?
Apologies for constantly buzzing you with change notifications. I thought I was done, but then I realized that Emacs counterpart needs updating too. Seemingly small change turned out to be a bit tricky. It's all good now - I checked it with different inputs. Thank you for your patience.
Great, I'll have a look tomorrow!
Aww. Only after figuring this out I just realized there's https://github.com/babashka/neil/issues/162 with a comment. Just following and grabbing that code would've been maybe simpler 🤦
Do you still want give action to this or keep your current code?
Do you still want give action to this or keep your current code?
I glanced over it, looks like it does pretty much almost the same thing. Either way, the bottom line - it works. If you have no objections, perhaps let's merge it and close both tickets. wdyt?
Oh wait. I stand corrected. It also adds GitHub too. We can leave "improve search" ticket open. I may take a look and try adding GH at some point.
I think adding a test here would be in order:
https://github.com/babashka/neil/blob/ff7aca40de042b398263d4cb6f9d77dbf73c5708/tests.clj#L78-L91
E.g. a test which searches for clojure on maven. After that, I think it'd be good to merge.
Please answer the following questions and leave the below in as part of your PR.
[ ] This PR corresponds to an #41
[ ] I have updated the CHANGELOG.md file with a description of the addressed issue.
Aww. Only after figuring this out I just realized there's #162 with a comment. Just following and grabbing that code would've been maybe simpler 🤦
Tested with the following:
Also neil.el was adjusted for the changes