Fetch latest stable slipset/deps-deploy, instead of hard-coding

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects

MIT License

360 stars 26 forks source link

Fetch latest stable slipset/deps-deploy, instead of hard-coding #206

Closed vedang closed 4 months ago

vedang commented 4 months ago

This is a minor change, which removes the hard-coding of the slipset/deps-deploy version in the build-alias function.

I have tested the change locally using bbin, and see that neil add build now uses slipset/deps-deploy {:mvn/version "0.2.2}

Closes: #205

Please answer the following questions and leave the below in as part of your PR.

[X] This PR corresponds to an issue with a clear problem statement.
[X] I have updated the CHANGELOG.md file with a description of the addressed issue.

borkdude commented 4 months ago

Some tests need some love I guess

vedang commented 4 months ago

My bad! I didn't run the tests locally.

I looked at the test results. They are unrelated to the current PR, but seem easy to fix. I'll fix them in a new commit and push the commit to this PR.

vedang commented 4 months ago

I've fixed the broken tests and explained the issue in the commit message. Please re-review

borkdude commented 4 months ago

@vedang Yes, indeed those failing tests weren't related to your PR, but seem suspicious because when you add a :tag argument, you should get that version instead of the absolute newest. I'll look at this after merging this one. Thanks a bunch!

borkdude commented 4 months ago

Oh I see, you explained it indeed well in the commit message:

git/find-github-tag 'clj-kondo/clj-kondo "v2022.03.08" return nil