search

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
377 stars 27 forks source link

suggestion: use DEPS_CLJ_TOOLS_DIR to detect DEPS_CLJ_TOOLS_VERSION #207

Closed icp1994 closed 8 months ago

icp1994 commented 8 months ago

If a user has set DEPS_CLJ_TOOLS_DIR, I think they would almost certainly want to use the version corresponding to ${DEPS_CLJ_TOOLS_DIR}/libexec/clojure-tools-${version}.jar. Currently they have to also provide DEPS_CLJ_TOOLS_VERSION to resolve conflict against the hard-coded version. This is a minor inconvenience for system wide installations in distros as when you update clojure to a more recent version, you will also need to update your ~/.profile or similar with the respective DEPS_CLJ_TOOLS_VERSION.

borkdude commented 8 months ago

I'm not sure how this exactly relates to neil specifically rather than deps.clj?

icp1994 commented 8 months ago

Oh, right - made the issue in wrong repo.