Closed teodorlu closed 5 months ago
Please answer the following questions and leave the below in as part of your PR.
[x] This PR corresponds to an issue with a clear problem statement.
[x] I have updated the CHANGELOG.md file with a description of the addressed issue.
[x] I have considered whether I should add more tests covering the code I've changed.
Effects:
neil/kaocha-alias
I think what I've got now is good. But I'd like to look into add-build, I think some code can be deleted.
add-build
LGTM! Feel free to ping me whenever you resolved the other minor things.
Ready to merge?
Yes, let's go!
Please answer the following questions and leave the below in as part of your PR.
[x] This PR corresponds to an issue with a clear problem statement.
[x] I have updated the CHANGELOG.md file with a description of the addressed issue.
[x] I have considered whether I should add more tests covering the code I've changed.
Problem: storing strings and converting to Clojure data is unncessary
Proposed solution: just store EDN
Effects:
neil/kaocha-alias
PR completion status
I think what I've got now is good. But I'd like to look into
add-build
, I think some code can be deleted.