babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
377 stars 27 forks source link

Store provided aliases as data instead of strings #221

Closed teodorlu closed 5 months ago

teodorlu commented 5 months ago

Please answer the following questions and leave the below in as part of your PR.

Problem: storing strings and converting to Clojure data is unncessary

Proposed solution: just store EDN

Effects:

PR completion status

I think what I've got now is good. But I'd like to look into add-build, I think some code can be deleted.

borkdude commented 5 months ago

LGTM! Feel free to ping me whenever you resolved the other minor things.

borkdude commented 5 months ago

Ready to merge?

teodorlu commented 5 months ago

Yes, let's go!