neil dep upgrade still upgrades git dep

[borkdude]

Repro:

{:deps {io.github.nextjournal/markdown {:git/sha "6683c48dfdb23404a23057817b6ac3acf0310bca" :neil/pinned true}}}

Run neil dep upgrade and it upgrades the dep.

[borkdude]

cc @teodorlu

[teodorlu]

I'll have a look.

[teodorlu]

I failed to reproduce the error with this test: https://github.com/teodorlu/neil/commit/e75658093f479d761e3201b67dc0a28def58c454 (I get all green tests, was expecting a red test).

I'll put some more effort into it later.

[borkdude]

I just tested with the CLI in a real project

https://www.michielborkent.nl https://www.eetvoorjeleven.nu

On Mon, 1 Jul 2024 at 16:21, Teodor Heggelund @.***> wrote:

I failed to reproduce the error with this test: @.*** https://github.com/teodorlu/neil/commit/e75658093f479d761e3201b67dc0a28def58c454 (I get all green tests, was expecting a red test).

I'll put some more effort into it later.

— Reply to this email directly, view it on GitHub https://github.com/babashka/neil/issues/229#issuecomment-2200286062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFSBW5XCS3PAENH7JZP7LZKFQVNAVCNFSM6AAAAABKFUS7CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGI4DMMBWGI . You are receiving this because you authored the thread.Message ID: @.***>

[borkdude]

Also :mvn/version dep is still upgrading, weirdly enough

[teodorlu]

Ok. Compiled script is in sync with source, right? (bb gen-script)

[borkdude]

I've tested with the brew-installed script, but I'll re-test with the local script

[borkdude]

Hmm, with the local script, it does work like expected. Seems like a release problem then...