babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
360 stars 26 forks source link

`dep upgrade`: do not add `:git/url` when not needed #233

Closed teodorlu closed 3 weeks ago

teodorlu commented 3 weeks ago

Please answer the following questions and leave the below in as part of your PR.

Design thoughts

I feel like the current design of dep-add and dep-upgrade is "creaking" a bit. Adding a blacklist option to dep-add to specifically omit :git/sha when upgrading dependencies feels like a hack.

Perhaps do-dep-upgrade shouldn't be using dep-add.

On the other hand:

  1. I don't have any specific proposals right now, just a feeling.
  2. Completely changing how dep-add and do-dep-upgrade works is a bit of work.
teodorlu commented 3 weeks ago

@borkdude This seems to be working as we want it to, though I'm not super happy with introducing the :omit-git-url option.

What do you think?

teodorlu commented 3 weeks ago

I'll fix the merge conflict.

teodorlu commented 3 weeks ago

(Closed by accident, reopened.)

borkdude commented 3 weeks ago

Thanks!

borkdude commented 3 weeks ago

Another way is to just add this dependency in your global .clojure/deps.edn profile under an alias and add this alias to your CIDER config.