Closed teodorlu closed 3 weeks ago
@borkdude This seems to be working as we want it to, though I'm not super happy with introducing the :omit-git-url
option.
What do you think?
I'll fix the merge conflict.
(Closed by accident, reopened.)
Thanks!
Another way is to just add this dependency in your global .clojure/deps.edn
profile under an alias and add this alias to your CIDER config.
Please answer the following questions and leave the below in as part of your PR.
[x] This PR corresponds to an issue with a clear problem statement.
[x] I have updated the CHANGELOG.md file with a description of the addressed issue.
[x] I have considered whether I should add more tests covering the code I've changed.
Design thoughts
I feel like the current design of
dep-add
anddep-upgrade
is "creaking" a bit. Adding a blacklist option todep-add
to specifically omit:git/sha
when upgrading dependencies feels like a hack.Perhaps
do-dep-upgrade
shouldn't be usingdep-add
.On the other hand:
dep-add
anddo-dep-upgrade
works is a bit of work.