search

babashka / pod-babashka-aws

Deprecated, use https://github.com/grzm/awyeah-api
Apache License 2.0
61 stars 14 forks source link

Broken message when missing GRAALVM_HOME #32

Closed lasiltan closed 3 years ago

lasiltan commented 3 years ago

in script/compile, missing GRAALVM_HOME is handled as such:

if [ -z "$GRAALVM_HOME" ]; then
    echo "Please set $GRAALVM_HOME"
    exit 1
fi

Resulting in the message Please set. Should be:

if [ -z "$GRAALVM_HOME" ]; then
    echo "Please set GRAALVM_HOME"
    exit 1
fi
borkdude commented 3 years ago

I agree. PR welcome.

lasiltan commented 3 years ago

I agree. PR welcome.

I don't think I have access to make a pr.

borkdude commented 3 years ago

Anyone can make a pull request against this repo. Only people with access can accept it.

lasiltan commented 3 years ago

https://github.com/babashka/pod-babashka-aws/pull/34

borkdude commented 3 years ago

Thanks!