search

babashka / pod-babashka-go-sqlite3

A babashka pod for interacting with sqlite3.
BSD 3-Clause "New" or "Revised" License
35 stars 4 forks source link

Catch when sqlite conn is not a string #14

Closed judepayne closed 1 year ago

judepayne commented 1 year ago

Fixes issues #13

judepayne commented 1 year ago

The Mac ci build looks to have failed, but I am working on a Mac :|

borkdude commented 1 year ago

@judepayne Let me fix that, just a moment

borkdude commented 1 year ago

@judepayne Please merge with master

judepayne commented 1 year ago

Done

borkdude commented 1 year ago

Did you push?

judepayne commented 1 year ago

I'm not totally au fait with the pr workflow. You might remember from my pr on the buddy pod!

I merged fix-nil-conn into main, and pushed main to my forked repo. The changes are there in the fork on main on Github. What else should I do or are are we good?

borkdude commented 1 year ago

@judepayne You should do it the other way around:

Update your PR branch with the latest commits from the main branch of this repo. And then push your PR branch. Those changes will then be reflected here and CI will be kicked off once again.

judepayne commented 1 year ago

Thanks. Done

borkdude commented 1 year ago

Thanks!