search

babashka / pods

Pods support for JVM and babashka
Eclipse Public License 1.0
121 stars 12 forks source link

Fix tests, remove accidental babashka code dependency, & add CI config #45

Closed cap10morgan closed 2 years ago

cap10morgan commented 2 years ago

When I went to add a test for the resolve bug fixed in #44 I noticed that other tests weren't passing and that it was because of some expectations broken by my changes in that same PR. That made me wonder why that hadn't been caught in CI and I noticed that no CI config was present in this repo. When I went to set that up, I realized I had inadvertently created a code dependency from pods -> babashka, which didn't seem good (so, for example, you couldn't run pods's tests unless it was embedded as a submodule in babashka).

So this PR fixes all of the above and adds a test for the original resolve bug too. Let me know if you want me to remove anything or split it out into a separate PR.

borkdude commented 2 years ago

@cap10morgan Thanks for the hard work! I've activated that project here now:

https://app.circleci.com/pipelines/github/babashka/pods