search

babashka / pods

Pods support for JVM and babashka
Eclipse Public License 1.0
120 stars 12 forks source link

Allow env vars OS_NAME & OS_ARCH to override os props #53

Closed cap10morgan closed 2 years ago

cap10morgan commented 2 years ago

This is helpful when caching pods in an artifact for deployment to another OS/arch than the one we're building on.

Closes #52

cap10morgan commented 2 years ago

Not quite ready yet. This allows overriding at compile time, but we want runtime. Another commit incoming...

cap10morgan commented 2 years ago

Another issue: Even w/ bb prepare it tries to run the pods to cache the metadata, which won't always work w/ this change. Need to think through that a bit...

cap10morgan commented 2 years ago

OK I think this is ready for review for now.

borkdude commented 2 years ago

@cap10morgan Should we add some documentation about this somewhere?

cap10morgan commented 2 years ago

@cap10morgan Should we add some documentation about this somewhere?

Yeah, probably. I can do that.

borkdude commented 2 years ago

Thanks! After that I'll merge this.