Add test support for `exec`

[lread]

New bb tasks:

• clean - delete build work
• test:bb - runs all tests under babashka
• test:native - runs exec tests against native image of run_exec.clj
• test:jvm - (renamed from test) runs non-exec tests under jvm clojure

CI:

• GitHub Actions updated to run native image tests
  • jobs renamed to match CircleCI naming convention
• CircleCI was doing a subset of GitHub Actions work, it now is a full reflection.
  • added jdk install support in script/circle_ci.clj
  • bootstrapping CI to be able to run bb and then scripting in bb is much more pleasant/maintainable than scripting in bash+Powershell
  • used jdk install support even on linux, instead of trying to to select jdk via docker image. This made config cleaner, allowed for consitent jdk selection across OSes and had surprisingly little performance hit especially after caching jdks.
  • installing jdks via bb hugely more performant than doing so via brew/scoop/chocolatey
  • jdk download urls, and shas discovered by disco API. See: https://github.com/foojayio/discoapi
• Both CIs are temporarily using a SHAPSHOT release of bb for babashka.process/exec reload support. We'll turf this after next release of babashka.

Add run_exec.clj - a wee program to exercise exec

• source and build support under ./test-native
• includes script-adjacent bb.edn to suport running as a script and reloading sources instead of using babashka built-in babashka.process
• specify babashka.process.test.reload system property to signal that run_exec.clj should reload babashka.process from sources when running from bb.
• note: test:native task does not natively compile tests, it only natively compiles run_exec.clj. It launches natively compiled run_exec.clj via jvm clojure and observes results for correctness.

Test utilities moved to babashka.process.test-utils so that they can be used by existing babashka.process-test and new:

• babashka.process-exec-test
• bb build scripts (specifically: test-native/bb.edn)

Add :ps-me to wee dummy wd.clj to support exec arg0 testing for macOS and Linux.

Add doc/dev.md with some relevant notes/pointers.

Other changes:

• deleted script/test bash script, it is replaced by bb tasks
• we now look for bb first in current dir, then on path. This seems the safer way to choose bb when running babashka.process tests from babashka
• tests now printing bb version to give confidence we are using the bb we want to be using

Bugs found and fixed as a result of testing:

• tests using java now understand that java executable path can contain spaces.
• test using javac seem to be happier running javac from same dir as source
• exec now converting :env and :extra-env keywords the same way process function do, see #123

Closes #117, Fixes #123

[lread]

Another biggie. Lemme know watcha think. As always, happy to collab and adapt.

After merge into babashka, we can adjust this:

;;;; babashka.process
;; test built-in babashka.process
(test-namespaces 'babashka.process-test)

;; test babashka.process from source
#_{:clj-kondo/ignore [:duplicate-require]}
(require '[babashka.process] :reload)
(test-namespaces 'babashka.process-test)

To maybe something like this:

;;;; babashka.process
;; test built-in babashka.process
(test-namespaces 'babashka.process-test)

(when (= "native" (System/getenv "BABASHKA_TEST_ENV"))
  ;; test babashka.process from source
  #_{:clj-kondo/ignore [:duplicate-require]}
  (require '[babashka.process] :reload)
  (System/setProperty "babashka.process.test.reload" "true")
  (test-namespaces 'babashka.process-test 'babashka.process-exec-test))

[borkdude]

I'll look at this soon, but I'm on a trip so it'll take a few days

On Tue, May 23, 2023 at 12:27 AM Lee Read @.***> wrote:

Another biggie. Lemme know watcha think. As always, happy to collab and adapt.

After merge into babashka, we can adjust this https://github.com/babashka/babashka/blob/0f85b02a82d4033f6b9cb697ec0e6919e7e0281b/test-resources/lib_tests/babashka/run_all_libtests.clj#L95-L102 :

;;;; babashka.process;; test built-in babashka.process (test-namespaces 'babashka.process-test) ;; test babashka.process from source

_{:clj-kondo/ignore [:duplicate-require]}

(require '[babashka.process] :reload) (test-namespaces 'babashka.process-test)

To maybe something like this:

;;;; babashka.process;; test built-in babashka.process (test-namespaces 'babashka.process-test)

(when (= "native" (System/getenv "BABASHKA_TEST_ENV")) ;; test babashka.process from source

_{:clj-kondo/ignore [:duplicate-require]}

(require '[babashka.process] :reload) (System/setProperty "babashka.process.test.reload" "true") (test-namespaces 'babashka.process-test 'babashka.process-exec-test))

— Reply to this email directly, view it on GitHub https://github.com/babashka/process/pull/131#issuecomment-1558113387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFSBXNWVKWLJMNXXVH4G3XHPR57ANCNFSM6AAAAAAYLA3SUE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- https://www.michielborkent.nl https://www.eetvoorjeleven.nu

[lread]

I'll look at this soon, but I'm on a trip so it'll take a few days

Thanks for the ping! Enjoy your trip!

[borkdude]

Thanks!