search

babashka / sci.configs

A collection of ready to be used SCI configs
https://babashka.org/sci.configs/
Other
20 stars 18 forks source link

add promesa/future in namespace #13

Closed avelino closed 1 year ago

avelino commented 1 year ago

ref: https://github.com/babashka/nbb/issues/282

borkdude commented 1 year ago

Since future is a macro we have to copy the source and also add the things it expands to (thread-call) if it's not in here yet. I think it would be good to add a test for it.

borkdude commented 1 year ago

Tests are failing because of:

and also add the things it expands to (thread-call) if it's not in here yet

borkdude commented 1 year ago

Can you merge with master? I bumped the JVM version for the promesa tests

avelino commented 1 year ago

Can you merge with master? I bumped the JVM version for the promesa tests

@borkdude I don't understand the error you gave, can you help me?

 :cause promesa/exec/ConcurrencyLimiter has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
borkdude commented 1 year ago

@avelino This means that the promesa library was compiled using Java 11 but we used Java 8 in CI. The .class file format changed in Java 11. I upgraded to Java 11 on master, this is why I recommending merging master into your PR branch

avelino commented 1 year ago

@borkdude sync to master branch

borkdude commented 1 year ago

@avelino I decided to help you finish things off a bit in a different PR which is now on main, since I needed this config myself ;-)